Allow daemonize in debug mode. #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f5995d to
df3c0e8
Compare
|
Need to make this change to get the failed test to pass: diff --git a/tests/events/suite/suite.rc b/tests/events/suite/suite.rc
index f44da3b29..f26e633c7 100644
--- a/tests/events/suite/suite.rc
+++ b/tests/events/suite/suite.rc
@@ -9,7 +9,7 @@
script = """
cylc reg $REG $DEF
echo "Sub-suite log file is: $PWD/$LOG"
-if cylc run --debug $REG > $LOG 2>&1; then
+if cylc run --no-detach --debug $REG > $LOG 2>&1; then
echo "ERROR: sub-suite did not abort as planned"
exit 1
else |
|
Thanks - I guess I missed that one! |
matthewrmshin
approved these changes
Nov 8, 2017
|
@oliver-sanders please sanity check. |
lib/cylc/daemonize.py
Outdated
| suite_pid = pid_str.rsplit("=", 1)[-1] | ||
| suite_port = server_str.rsplit(":", 1)[-1] | ||
| else: | ||
| if len(open(log_fname).readlines()) < 2: |
There was a problem hiding this comment.
To avoid reading the entire log file we could do something like:
with open(log_fname) as log_f
try:
first_two_lines = next(log_f), next(log_f)
except StopIteration:
continueThere was a problem hiding this comment.
Good idea, will do that...
|
@oliver-sanders - comment addressed |
matthewrmshin
added a commit
to matthewrmshin/rose
that referenced
this pull request
Nov 14, 2017
matthewrmshin
added a commit
to matthewrmshin/rose
that referenced
this pull request
Nov 14, 2017
oliver-sanders
added a commit
to metomi/rose
that referenced
this pull request
Nov 14, 2017
Fix test breakages due to cylc/cylc-flow#2475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing annoyance (for me anyway):
--no-detachand--debugshould be orthogonal.