suite_state: don't return null db results #2440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cylc suite-state
fails if querying a task output message from a task proxy that exists (or existed before suite shutdown) but which has not generated its message output yet. E.g.:Run this suite to completion. It shuts down with waiting task proxies recorded in the final+1 cycle (2013):
Querying foo's output message is fine for succeeded instances, and non-existent instances:
But not for the instance that exists but has not recorded an output yet:
This seems to be because the DB
task_outputs
table has a column for the messages of all existing task proxies that register outputs, unpopulated until the message is received, until which time a query returns(None, )
rather thanNone
.This change fixes it.