group setting now in suite meta #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f299fb0 to
8616052
Compare
oliver-sanders
approved these changes
Sep 22, 2017
bin/cylc-scan
Outdated
| try: | ||
| title = suite_identity[KEY_META].get(KEY_TITLE) | ||
| except KeyError: | ||
| title = suite_identity.get(KEY_TITLE) |
There was a problem hiding this comment.
Could you put comments on these lines explaining that they are there for compatibility reasons.
dvalters
reviewed
Sep 28, 2017
doc/src/cylc-user-guide/suiterc.tex
Outdated
|
|
||
| A single line group name for a suite. It is displayed in the gscan | ||
| window and can be used as a way of grouping related suites together. | ||
| \lstinline=cylc show= command. |
There was a problem hiding this comment.
Should this say "...with the cylc show command? (It was in current docs on master too)
There was a problem hiding this comment.
I think this was a typo as cylc show doesn't know about groups - they're only used by gscan, right? ... in which case maybe this should read: A group name for a suite. In the gscan GUI, suites with the same group name can be collapsed into a single state summary when the "group" column is displayed.
|
(note new comment from me on the "outdated" change above) |
|
@hjoliver New comment note implemented. |
dvalters
approved these changes
Sep 29, 2017
hjoliver
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
groupsetting to under[meta]as well.On suite
identifyAPI call, return full set of suite[meta]settings ondescriptionprivilege level.