Reset cylc monitor if connection lost #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
commented
Sep 7, 2017
bin/cylc-monitor
Outdated
| @@ -138,7 +141,8 @@ The USER_AT_HOST argument allows suite selection by 'cylc scan' output: | |||
| self.pclient.get_suite_state_summary()) | |||
| except Exception as exc: | |||
| print >> sys.stderr, "\033[1;37;41mERROR\033[0m", str(exc) | |||
| self.pclient.reset() | |||
There was a problem hiding this comment.
(I suspect client reset use to have the desired effect - although I haven't looked back to check - but now it is just a stub)
4979494 to
d3c4d94
Compare
matthewrmshin
approved these changes
Sep 7, 2017
|
PEP8 issue + a hanging test. |
515e5eb to
b6ba2b2
Compare
|
Rebased, deconflicted, and pep8'ed. |
dvalters
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
cylc monitorreset and reconnect if a suite shuts down and restarts on a different port.