Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace to multi inheritance error message #2416

Merged
merged 2 commits into from
Sep 5, 2017
Merged

Add namespace to multi inheritance error message #2416

merged 2 commits into from
Sep 5, 2017

Conversation

benfitzpatrick
Copy link
Contributor

The current error message for bad multiple inheritance doesn't include the name of the family or task that led to the error - this change adds it.

@matthewrmshin matthewrmshin added this to the soon milestone Aug 31, 2017
@hjoliver hjoliver modified the milestones: next release, soon Sep 4, 2017
@hjoliver hjoliver self-requested a review September 4, 2017 22:33
@hjoliver
Copy link
Member

hjoliver commented Sep 4, 2017

Welcome back @benfitzpatrick 🍺

hjoliver
hjoliver approved these changes Sep 4, 2017
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, tests as working.

@hjoliver
Copy link
Member

hjoliver commented Sep 4, 2017

@matthewrmshin - can you assign a second review, according to availability.

matthewrmshin
matthewrmshin approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks OK. The next time we look at the code, I think we should modify it to raise a more specific error than the general Exception. For the error message it writes, this should really be a cylc.config.SuiteConfigError.

@matthewrmshin matthewrmshin merged commit baa97cd into cylc:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@benfitzpatrick benfitzpatrick

Labels
None yet
Projects
None yet
Milestone
cylc-7.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benfitzpatrick @hjoliver @matthewrmshin