Fix redirection of stdout and stderr to suite logs #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ae2978 to
97f2a3c
Compare
97f2a3c to
c1d1553
Compare
|
The test can be cleaned up a little, it'll do for now. I'll add a further test for sequential timestamps next week, these changes can go into a future cylc release. |
hjoliver
reviewed
Aug 27, 2017
lib/cylc/scheduler.py
Outdated
| @@ -217,14 +217,17 @@ def start(self): | |||
| self.suite_db_mgr.restart_upgrade() | |||
|
|
|||
| try: | |||
| if not self.options.no_detach and not cylc.flags.debug: | |||
| detatch = not (self.options.no_detach or cylc.flags.debug) | |||
There was a problem hiding this comment.
Spelling: should be "detach" (although it's not a bug, as consistently misspelled!)
|
The code looks fine, but the test always passes for me on master - presumably that should not happen? |
|
Missed a |
matthewrmshin
approved these changes
Aug 29, 2017
|
All good, thanks. @matthewrmshin - note I've updated the change log for 7.5.0, and will attempt to make the release Wednesday night. I'm in a workshop all day tomorrow, and on leave Thursday and Friday. Worst case, release on the weekend... |
hjoliver
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2411
Changes: