ghost nodes for cylc graph. #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/cylc/cylc_xdot.py
Outdated
| # Style regular (task) nodes. | ||
| node.attr['shape'] = 'oval' | ||
| if not any(seq.is_on_sequence(get_point(point)) for seq in | ||
| self.suiterc.taskdefs[name].sequences): |
There was a problem hiding this comment.
In essence of our recent validate optimisation, we know that sequence calculations are expensive. I wonder if it is worth caching the results here?
4a109b4 to
2c21e4d
Compare
lib/cylc/cylc_xdot.py
Outdated
| return False | ||
| else: | ||
| temp = sequence.is_on_sequence(get_point(point)) | ||
| if cache: |
There was a problem hiding this comment.
This won't work if cache is empty?
matthewrmshin
approved these changes
Jul 10, 2017
|
(Branch in conflict.) |
03002df to
411a392
Compare
|
( |
98e69b0 to
bf367f8
Compare
|
(conflicts) |
bf367f8 to
3f18786
Compare
|
(resolutions) |
|
(heh heh 😁 ) |
hjoliver
reviewed
Jul 25, 2017
| node "fennel.1" "fennel\n1" unfilled box black | ||
| node "grape.1" "grape\n1" unfilled box black | ||
| node "artichoke.1" "artichoke\n1" unfilled ellipse black | ||
| node "arugula.1" "arugula\n1" unfilled ellipse black |
There was a problem hiding this comment.
(box/ellipse ... and at first I was slightly concerned about the +/- 900 lines change size)
There was a problem hiding this comment.
Yes, its been fun changing all those lines!
|
I thought you had broken right-click group/ungroup of families, but it turns out I'd checked out your other branch with identical branch name minus the final 'w' in '-view'! 1 test failing, but otherwise looks good to me (tested with nested families too). |
hjoliver
approved these changes
Jul 25, 2017
|
Can be merged if tests pass now. Over 'n out. |
|
Actually, you could mention this at the end of the CUG section "How The Graph Determines Task Instantiation". |
|
I'll take the liberty to merge this. |
matthewrmshin
added a commit
that referenced
this pull request
Aug 7, 2017
…-fix docs: update documentation after #2346
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Jun 10, 2022
* Closes cylc#4638 * Fixes a regression where `cylc graph` was no longer rendering un-satisfiable dependencies differently (see cylc#2346 for original implementation). * Restores the missing functionality to `cylc graph` and also adds warnings so un-satisfiable dependencies can be detected more easily. * Refactors `cylc graph` a little, main change is that graphviz output is no longer achieved by re-processing the reference output using regexes. It's now generated from the graph directly.
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Jun 10, 2022
* Closes cylc#4638 * Fixes a regression where `cylc graph` was no longer rendering un-satisfiable dependencies differently (see cylc#2346 for original implementation). * Restores the missing functionality to `cylc graph` and also adds warnings so un-satisfiable dependencies can be detected more easily. * Refactors `cylc graph` a little, main change is that graphviz output is no longer achieved by re-processing the reference output using regexes. It's now generated from the graph directly.
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Jun 10, 2022
* Closes cylc#4638 * Fixes a regression where `cylc graph` was no longer rendering un-satisfiable dependencies differently (see cylc#2346 for original implementation). * Restores the missing functionality to `cylc graph` and also adds warnings so un-satisfiable dependencies can be detected more easily. * Refactors `cylc graph` a little, main change is that graphviz output is no longer achieved by re-processing the reference output using regexes. It's now generated from the graph directly.
7 tasks
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Jun 14, 2022
* Closes cylc#4638 * Fixes a regression where `cylc graph` was no longer rendering un-satisfiable dependencies differently (see cylc#2346 for original implementation). * Restores the missing functionality to `cylc graph` and also adds warnings so un-satisfiable dependencies can be detected more easily. * Refactors `cylc graph` a little, main change is that graphviz output is no longer achieved by re-processing the reference output using regexes. It's now generated from the graph directly.
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this pull request
Jun 14, 2022
* Closes cylc#4638 * Fixes a regression where `cylc graph` was no longer rendering un-satisfiable dependencies differently (see cylc#2346 for original implementation). * Restores the missing functionality to `cylc graph` and also adds warnings so un-satisfiable dependencies can be detected more easily. * Refactors `cylc graph` a little, main change is that graphviz output is no longer achieved by re-processing the reference output using regexes. It's now generated from the graph directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2287
Graph view now displays tasks using ovals rather than boxes to match gcylc.
Before
After
ng)