Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send job xtrace to a new log file. #2314

Merged
merged 3 commits into from
Jun 7, 2017

Conversation

hjoliver
Copy link
Member

Use BASH_XTRACEFD to de-clutter debug mode job output by sending xtrace to a separate job log file, leaving job.out and job.err as normal. @matthewrmshin - see what you think...

@hjoliver hjoliver added this to the next release milestone May 31, 2017
@hjoliver hjoliver self-assigned this May 31, 2017
@hjoliver hjoliver requested a review from matthewrmshin May 31, 2017 23:07
@hjoliver
Copy link
Member Author

This causes some tests to fail; I'll fix them if others agree this is a good change.

@matthewrmshin
Copy link
Contributor

Agree with the change. I am wondering if it may be better to call the file job.xtrace to make it clear that it is debugging information from xtrace?

@hjoliver
Copy link
Member Author

hjoliver commented Jun 3, 2017

... better to call the file job.xtrace ...

done.

@hjoliver hjoliver force-pushed the master branch 3 times, most recently from add7f5b to 7162266 Compare June 4, 2017 09:03
@matthewrmshin
Copy link
Contributor

@oliver-sanders please sanity check.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@oliver-sanders oliver-sanders merged commit b120ff3 into cylc:master Jun 7, 2017
matthewrmshin added a commit to matthewrmshin/cylc-flow that referenced this pull request Jun 21, 2017
Tests probably broken by cylc#2314 and cylc#2319.
matthewrmshin added a commit to matthewrmshin/rose that referenced this pull request Jun 26, 2017
oliver-sanders added a commit to metomi/rose that referenced this pull request Jun 27, 2017
@hjoliver hjoliver deleted the bash-xtracefd branch August 28, 2017 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants