cat log to editor, remote file fix. #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
suggested changes
May 19, 2017
bin/cylc-cat-log
Outdated
| # Copy local or remote job file to a local temp file. | ||
| viewfile = mkstemp(dir=cylc_tmpdir)[1] | ||
| if user_at_host: | ||
| cp = 'scp %s:%s %s' % (user_at_host, filename, viewfile) |
There was a problem hiding this comment.
You may want to use the scp command configuration from global.rc?
bin/cylc-cat-log
Outdated
| if user_at_host: | ||
| cp = 'scp %s:%s %s' % (user_at_host, filename, viewfile) | ||
| else: | ||
| cp = 'cp %s %s' % (filename, viewfile) |
There was a problem hiding this comment.
Best to set up the cp command as a list at this point? In case any file name contains space characters, etc?
|
@matthewrmshin - feedback addressed. |
c5153f0 to
4e71383
Compare
matthewrmshin
approved these changes
May 22, 2017
oliver-sanders
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the bug in 7.4.0 reported on the Cylc Google Group today by @MartinDix.
Still needs a test for remote job file view.(I should have noticed this - had tested with a remote task but shared filesystem)