Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: add -Y only if necessary #2252

Merged
merged 1 commit into from
May 5, 2017
Merged

ssh: add -Y only if necessary #2252

merged 1 commit into from
May 5, 2017

Conversation

matthewrmshin
Copy link
Contributor

Should close #2248.

@matthewrmshin matthewrmshin added this to the next release milestone Apr 24, 2017
@matthewrmshin matthewrmshin self-assigned this Apr 24, 2017
@matthewrmshin
Copy link
Contributor Author

I have also changed the global configurations remote shell template and remote copy template to ssh command and scp command respectively. They are no longer templates, and usage such -Y relies on ssh, so we might as well make it explicit.

I have removed bin/cylc-job-logs-retrieve as it should no longer be used.

arjclark
arjclark reviewed May 4, 2017
View reviewed changes
Copy link
Contributor

@arjclark arjclark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming @hjoliver is happy with deprecation of config items.

You appear to have snuck in retirement of "cylc get-job-logs-retrieve" (not apparent till you read your comment rather than title and opening comment) - ok by me so long as @hjoliver is happy.

@hjoliver
Copy link
Member

hjoliver commented May 5, 2017

@arjclark - I'm happy.

@hjoliver hjoliver merged commit 64c216a into cylc:master May 5, 2017
@matthewrmshin matthewrmshin deleted the ssh-y branch May 5, 2017 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@arjclark arjclark arjclark approved these changes

Assignees

@matthewrmshin matthewrmshin

@hjoliver hjoliver

@arjclark arjclark

Labels
None yet
Projects
None yet
Milestone
cylc-7.4.0
Development

Successfully merging this pull request may close these issues.

Cylc remote X forwarding
3 participants
@matthewrmshin @hjoliver @arjclark