Allow "cylc graph --help" in absence of X environment. #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
approved these changes
Apr 23, 2017
|
@arjclark please sanity check. |
arjclark
suggested changes
Apr 24, 2017
| @@ -204,6 +207,9 @@ def main(): | |||
|
|
|||
| (options, args) = parser.parse_args() | |||
|
|
|||
| if no_x: | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
Could we just return/sys.exit(0) if --help is used? Doesn't seem like it should be a non-zero exit code as its successfully printing help details...
There was a problem hiding this comment.
--help causes the script to exit before this point... and I just confirmed this really is the case by faking a gtk ImportError.
arjclark
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(what it says).