gcylc: dot view - maintain user selection during update #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15c8c6e to
bcecd46
Compare
lib/cylc/gui/updater_dot.py
Outdated
| Warning: This method has not been tested with multiple selection. | ||
|
|
||
| """ | ||
| def should_select_row(model, path, iter_, selection): |
There was a problem hiding this comment.
Any reason why this function/method needs to be embedded?
There was a problem hiding this comment.
The logic doesn't really make sense within DotUpdater so I encapsulated it (pep227). I could convert it to a lambda if you prefer.
There was a problem hiding this comment.
(The method, however, does refer to self.)
There was a problem hiding this comment.
Once this is resolved happy for this to be merged.
There was a problem hiding this comment.
@matthewrmshin Code now moved into a static method.
hjoliver
approved these changes
Mar 28, 2017
|
(sorry - didn't notice I was not assigned as a reviewer 😬) |
matthewrmshin
approved these changes
Mar 29, 2017
|
Doubly approved already, so I think we can remove @arjclark as reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1707
Doesn't go as far as Ben's incremental build suggestion (#1707 (comment)).