Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SGE directives with space in key. #2215

Merged
merged 2 commits into from
Mar 27, 2017
Merged

Fix SGE directives with space in key. #2215

merged 2 commits into from
Mar 27, 2017

Conversation

hjoliver
Copy link
Member

Reported at BoM: under SGE the new(ish) execution time limit setting gets formatted as:

#$ -l h_rt 0:20:00

instead of

#$ -l h_rt=0:20:00

This patch fixes the problem.

@hjoliver hjoliver added the bug Something is wrong :( label Mar 27, 2017
@hjoliver hjoliver added this to the next release milestone Mar 27, 2017
@hjoliver hjoliver self-assigned this Mar 27, 2017
@hjoliver hjoliver requested a review from matthewrmshin March 27, 2017 00:05
matthewrmshin
matthewrmshin approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. It is good that this is finally being tested by real users.

@matthewrmshin matthewrmshin merged commit 07c5c42 into cylc:master Mar 27, 2017
@matthewrmshin
Copy link
Contributor

(No need to have 2nd review.)

@hjoliver hjoliver deleted the fix-sge-directives branch March 27, 2017 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

Assignees

@hjoliver hjoliver

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-7.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hjoliver @matthewrmshin