Fix broadcast submission timeout restart #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suites were dying on restart when there is a submission timeout broadcast. On restart, submission timeout values became unicode, which caused job submission timeout logic to die. This fix ensures that the values are converted back to float.
37811ba to
b839795
Compare
oliver-sanders
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suites were dying on restart when there is a submission timeout
broadcast. On restart, submission timeout values became unicode, which
caused job submission timeout logic to die. This fix ensures that the
values are converted back to float.
(We thought #2166 would fix the issue, but it looks like the real problem was overlooked.)