Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcylc - improved filtering dialog #2142

Merged
merged 1 commit into from
Feb 6, 2017
Merged

gcylc - improved filtering dialog #2142

merged 1 commit into from
Feb 6, 2017

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Feb 5, 2017 •
edited
Loading

Adds task state Select All and Select None buttons; a Reset button for the filter text entry; and clearer tooltip info.

foo

@hjoliver hjoliver added this to the soon milestone Feb 5, 2017
@hjoliver hjoliver self-assigned this Feb 5, 2017
@hjoliver hjoliver force-pushed the gcylc-filter-select-all branch from ff2b939 to a24386f Compare February 5, 2017 19:31
@hjoliver hjoliver force-pushed the gcylc-filter-select-all branch from a24386f to 31b0bf9 Compare February 5, 2017 19:32
matthewrmshin
matthewrmshin approved these changes Feb 6, 2017
View reviewed changes
Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as working.

@oliver-sanders oliver-sanders merged commit fcb9824 into cylc:master Feb 6, 2017
@hjoliver hjoliver deleted the gcylc-filter-select-all branch February 6, 2017 19:22
@hjoliver hjoliver modified the milestones: next release, soon Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@hjoliver hjoliver

Labels
None yet
Projects
None yet
Milestone
cylc-7.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@hjoliver @matthewrmshin @oliver-sanders