cylc gscan: add --name option #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like PEP8 test failing on Travis CI. |
|
Pep8 fixed. |
| name_pattern = name | ||
| else: | ||
| name_pattern = ['.*'] | ||
| name_pattern = "(" + ")|(".join(name_pattern) + ")" |
There was a problem hiding this comment.
You may want to compile the pattern here with re.compile - to catch any re.error that it may generate. (In addition, using a compiled regular expression object's .match method for matching a string should in theory be faster than using re.match.)
There was a problem hiding this comment.
Now being compiled.
| @@ -1126,6 +1144,9 @@ def update(self): | |||
| self.tasks_by_state[(suite, host)] = suite_info[ | |||
| 'tasks-by-state'] | |||
|
|
|||
| if not (re.match(self.name_pattern, suite)): | |||
There was a problem hiding this comment.
You should now be able to do self.name_pattern.match(suite).
oliver-sanders
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1625
Adds --name option for filtering suites to display in gscan as per cylc scan.
@oliver-sanders - please review1
@matthewrmshin - please review2