job poll intervals now host based on global.rc #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e1fa12 to
c9e84f7
Compare
Poll jobs on job host if intervals are set and the delays are done, regardless of task communication method. Rename `TryState` to `TaskActionTimer`. Remove `PollTimer`, and use `TaskActionTimer` for poll timers.
c9e84f7 to
2d704e2
Compare
hjoliver
reviewed
Oct 25, 2016
| 'submission polling intervals': vdr( | ||
| vtype='interval_minutes_list', default=[]), | ||
| 'execution polling intervals': vdr( | ||
| vtype='interval_minutes_list', default=[]), |
There was a problem hiding this comment.
You haven't removed these items from their original locations in the config dict (the deprecation mechanism doesn't require the originals to be kept).
| @@ -120,16 +119,17 @@ def is_timeout_set(self): | |||
| """Return True if timeout is set.""" | |||
| return self.timeout is not None | |||
|
|
|||
| def next(self): | |||
| def next(self, no_exhaust=False): | |||
| """Return the next retry delay if there is one, or None otherwise.""" | |||
There was a problem hiding this comment.
Doc-string now inaccurate if no_exhaust is True - repeats the last delay interval indefinitely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow submission and execution polling intervals per host on
global.rc. This allows regular health checks to be site configurable regardless of task communication methods.Rename
TryStatetoTaskActionTimer. RemovePollTimer, and useTaskActionTimerfor poll timers.