Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc show: multi-task interface #2046

Merged
merged 1 commit into from
Oct 31, 2016
Merged

cylc show: multi-task interface #2046

merged 1 commit into from
Oct 31, 2016

Conversation

matthewrmshin
Copy link
Contributor

  • cylc show: can now show multiple task name and/or task ID.
  • cylc gui: fix view prerequisites for runahead tasks.

Fix #2045. @hjoliver @arjclark please review.

@matthewrmshin matthewrmshin added the bug Something is wrong :( label Oct 13, 2016
@matthewrmshin matthewrmshin added this to the next release milestone Oct 13, 2016
@matthewrmshin matthewrmshin mentioned this pull request Oct 13, 2016
Merged
@arjclark
Copy link
Contributor

Review 2 Looks OK to me. No problems from the test-battery in my environment.

@arjclark arjclark removed their assignment Oct 14, 2016
@hjoliver
Copy link
Member

hjoliver commented Oct 25, 2016 •
edited
Loading

@matthewrmshin - the multi-task interface doesn't seem to have the desired effect. E.g. cylc show foo */baz returns nothing in a test suite foo with a task baz instance in several cycle points (the same args do work e.g. for cylc remove). Which suggests the new functionality needs a test too. (maybe a prior rebase broke it...)

@matthewrmshin
Copy link
Contributor Author

HI @hjoliver I am on leave today and tomorrow (Tuesday and Wednesday). I'll take a look at this again when I am back at work on Thursday.

@matthewrmshin
cylc show: multi-task interface
a027a88 
* cylc show: can now show multiple task name and/or task ID.
* cylc gui: fix view prerequisites for runahead tasks.
@matthewrmshin
Copy link
Contributor Author

Logic for the CYCLE/TASK syntax should now be fixed. New test added. Branch re-based and squashed.

hjoliver
hjoliver approved these changes Oct 31, 2016
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@hjoliver hjoliver merged commit 72cc728 into cylc:master Oct 31, 2016
@matthewrmshin matthewrmshin deleted the cylc-show-multitask branch October 31, 2016 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@hjoliver hjoliver

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-7.0.0
Development

Successfully merging this pull request may close these issues.

"view prerequisites" fails for tasks in the runahead pool
3 participants
@matthewrmshin @arjclark @hjoliver