1905: Don't ignore dependencies in tasks inserted before start pt. #1921
Conversation
| @@ -109,7 +110,8 @@ def set_condition(self, expr): | |||
| try: | |||
| foo = m.group().split(".")[1].rstrip() | |||
| if get_point(foo) < self.start_point: | |||
There was a problem hiding this comment.
I guess we can combine the ifs?
|
In your example suite, if I insert the family at |
Not sure I understand your question - if the cycle at which a task is inserted is prior to the start cycle (start point/whatever) then its prerequisites are not filtered. You see this in the example suite as the task (foo) is set to ready in order for it to be able to run. |
|
@benfitzpatrick - if statement tweaked. |
|
@benfitzpatrick - I've added the extra test to ensure future continuation of functionality as we discussed yesterday. |
|
Ok, looks good to me |
|
Oops - merged without @hjoliver. |
|
Any retrospective approval? |
|
Retrospectively tested and approved. (However, an email coming on a related issue...) |
Closes #1905
This change means that any task inserted prior to the start point will maintain its prerequisites rather than having them wiped out. Existing behaviour maintained (no changes needed to existing tests) and new test added for this desired behaviour.
@hjoliver - please review 1
@benfitzpatrick - please review 2