Fix reload-alteration of a reload-removed then reload-added task #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17fe934 to
3bdb067
Compare
|
Looks ok to me and test-battery passing in my environment. Over to you @hjoliver - please double check I haven't missed any unforseen consequence from this as I'm generally scared of reloads as it is 😬 |
|
All good here, and I don't think there will be any unforeseen consequences! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1759. A task that became a reload orphan always stayed an orphan in future reloads and couldn't be changed via reload.
It also fixes a small issue I found when debugging - reload in itself doesn't trigger a state summary update. This isn't always necessary (e.g. when just altering the runtime) but seems like a good idea.
@arjclark, @hjoliver please review.