-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cylc unregister: skip suites with port files #1802
Conversation
aebb5b7
to
cb59c47
Compare
Branch needs updating. |
try: | ||
os.rmdir(tmp) | ||
except OSError: | ||
break | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block (in master too) is a bit too simplistic to do what it's supposed to - i.e. remove all empty directories left by unregistering and deleting a bunch of suites. To see this, try cylc import examples $TMPDIR
then cylc unreg -d cylc-.*
and look in $TMPDIR
. However, I doubt that anyone stores suites in directory trees that reflect the suite name hierarchy as I originally intended (e.g. nwp.test1
and nwp.test2
stored in nwp/test1/
and nwp/test2
) - certainly Rose users don't - and unregisters them en-masse ... so maybe we should just remove this feature.
Also ensure that `cylc unregister bar` does not unregister a suite called `foobar`.
cb59c47
to
4f38b06
Compare
All comments addressed. Branch re-based. |
Review 1 - good, test battery passing. |
Looks OK to me. No problems from the test-battery in my environment. |
Also ensure that
cylc unregister bar
does not unregister a suitecalled
foobar
.Close #1796.