-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up task output message handling #1761
Conversation
Re deprecation of cycle point offset placeholders in message trigger strings ... this:
is now equivalent to this for all practical purposes:
On master, we enforce the use of the offset placeholders in message output strings in order to distinguish the message strings emitted by successive instances of I've changed the documentation and examples to remove all references to in-string offset placeholders, but it's still supported in the code for backward compatibility. |
else: | ||
offset = get_interval_cls().get_null() | ||
# else: Plain message, no offset. | ||
return offset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was duplicated in two places.
9932fc5
to
fa09fb8
Compare
bc2cbd0
to
20bb930
Compare
20bb930
to
bbf4ccc
Compare
@matthewrmshin - please review or re-assign. Test battery passes here. |
|
global warned | ||
global BCOMPAT_MSG_RE_C5 | ||
global BCOMPAT_MSG_RE_C6 | ||
global DEPRECN_WARN_TMPL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to declare global
for constants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yeah, just for warned
Looking good. Some minor issues noted. Test OK (with and without site/user global configuration) in my environment apart from the time zone problem in the new test. @arjclark please review 2. |
All comments addressed. |
Tests all good. |
Looks ok to me. Test battery passing in my environment. |
Close #1604.
task_proxy.py
by getting rid of a bunch of Task ID prepend/remove operations.[task-id] ... task-id succeeded
is now just[task-id] ...succeeded
, etc.output.py:output
tomessage_output.py:MessageOutput
- as this class is only used for message outputs).