Pyro 3.16: include in cylc distribution + related improvements #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is done in 3 stages:
|
|
Nice. I guess we can update (simplify) installation documentation in the CUG now. |
|
Comparing master and this branch with |
|
(I'll do a |
|
@hjoliver @benfitzpatrick please review. (It is perhaps easiest to review this change by looking at the individual changesets.) |
|
Review 1: looks good, test battery passes. Tested with a short EXPIRE time. Over to you Ben... |
By default, the singletons will expire after 1 hour.
Also: * Modified *passwordless* ssh to *non-interactive* ssh as requirements.
|
(Branch re-based against master.) |
| @@ -445,6 +441,12 @@ \section{Required Software} | |||
| \item ImageMagick (for image scaling) | |||
| \end{myitemize} | |||
|
|
|||
| Note: Older versions of cylc requires Pyro-3 (Python Remote Objects). Current | |||
|
One comment, otherwise looks fine to me. |
|
Typo fixed. |
benfitzpatrick
added a commit
that referenced
this pull request
Mar 18, 2016
Pyro 3.16: include in cylc distribution + related improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pyro 3.16 under
lib/Pyro/.Modify Pyro to memoize
socket.gethost*calls with a 1 hour expiry.cylc.suite_hostas well.Follow on from #1732.