Initialise process pool early #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move "process pool size" setting from suite to site/user. Reduce memory footprint at point of fork to reduce memory footprint at the start of each child process.
|
@hjoliver please review. |
|
Looks good. |
hjoliver
added a commit
that referenced
this pull request
Aug 20, 2014
Initialise process pool early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce memory footprint at point of fork to reduce memory footprint at the start of each child process.
Move "process pool size" setting from suite to site/user.
cylc runto not load the suite into memory before the forks.As each process starts with the memory footprint of the parent,
the current logic would created a problem for big suites.
After this change, memory usage for the workers should become independent of the size of the suite.
See also #1012.