Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1008: more minimal start-up dependencies #1026

Conversation

benfitzpatrick
Copy link
Contributor

This closes #1008.

This adds dependencies on R1 start-up/async tasks only at the first cycle
point of the dependent task.

@hjoliver, please review.

@benfitzpatrick benfitzpatrick added this to the cylc-6 milestone Jul 21, 2014
@arjclark
Copy link
Contributor

@benfitzpatrick - is #747 relevant here?

@benfitzpatrick
Copy link
Contributor Author

I think #747's problem will be OK because the start-up mechanism is different,
and they now behave like normal task dependencies after a bit of graph-hacking
at the beginning of the run.

@hjoliver
Copy link
Member

Runs correctly, but graphing is broken if a start-up task is present: the general cycling gets missed.

@benfitzpatrick
Copy link
Contributor Author

I keep creating these graphing problems - I think I'll write some "dot" file tests for
cylc graph.

@benfitzpatrick
Copy link
Contributor Author

Runs correctly, but graphing is broken if a start-up task is present: the general cycling gets missed.

This looks OK to me for the r1_multi_start_back_comp_start_up suite - which
suite can reproduce it?

@hjoliver
Copy link
Member

[scheduling]
    initial cycle time = 2014080800
    [[special tasks]]
        start-up = start
    [[dependencies]]
        [[[0]]]
            graph = start => foo

cylc graph SUITE 2014080800 2014081000, on master:
g1

On your branch:
g2

@hjoliver
Copy link
Member

We need to get this show on the road, and this fixes the run time behaviour, so I'm merging this and referring the residual graphing problem back to the main issue #1008.

hjoliver added a commit that referenced this pull request Jul 30, 2014
…dep-tweak

#1008: more minimal start-up dependencies
@hjoliver hjoliver merged commit 8c908cd into cylc:119.iso8601-cycling Jul 30, 2014
@benfitzpatrick benfitzpatrick deleted the 1008.start-up-back-comp-dep-tweak branch August 20, 2014 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants