Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#119 - specify runahead limit as a duration #983

Closed
hjoliver opened this issue Jun 17, 2014 · 4 comments
Closed

#119 - specify runahead limit as a duration #983

hjoliver opened this issue Jun 17, 2014 · 4 comments
Assignees
Milestone

Comments

@hjoliver
Copy link
Member

Currently on the ISO8601 feature branch (see #119) the runahead limit is specified as a multiple of the smallest cycling interval in the suite, which defaults to 2. However, it would probably be better for users who want to override this default to be able to specify a duration (in ISO8601 format, or an integer for integer cycling).

The default value can still be computed as twice the smallest cycling interval. Note that the "smallest cycling interval" is as determined by the recurrence expressions used, it does not get adjusted for tasks that appear in multiple recurrences, which can make the interval between successive task instances smaller than this. However, this probably doesn't matter much so long as how the default is determined is clearly documented.

@hjoliver hjoliver added this to the cylc-6 milestone Jun 17, 2014
@hjoliver hjoliver self-assigned this Jun 17, 2014
@hjoliver
Copy link
Member Author

This needs to work via CLI and GUI, which currently still expect integer hours.

@hjoliver
Copy link
Member Author

hjoliver commented Jul 6, 2014

@benfitzpatrick - I was about to start working on this, and had got as far as revising the documentation when I thought I'd better check that you hadn't also started on it, since it is closely related to #1007... and it seems you have done, in a branch "119.restore-runahead-limit". So, I'll stop where I'm at, but could you take my documentation, which is a slightly more general rewrite than strictly necessary for this issue, and merge with your branch as appropriate: bbdef52

One question, I was going to go for a default runahead limit of twice the smallest interval specified in the graph section headings, without accounting for tasks that have a smaller cycling interval than that because they appear in multiple sections. A quick look at your code suggests you're going for the full solution ... but I think we should at least consider whether the simpler version might be better because it would be easier for users to see at a glance where the default comes from.

@benfitzpatrick
Copy link
Contributor

The multiple section problem is really because when a user writes:

    [[[T00, T06, T12, T18]]]

they mean:

    [[[T00]]]
    [[[T06]]]
    [[[T12]]]
    [[[T18]]]

which is:

    [[[T00/P1D]]]
    [[[T06/P1D]]]
    [[[T12/P1D]]]
    [[[T18/P1D]]]

and the actual cycling interval isn't easy to get out. This may have been true in
current cylc master as well - not sure.

benfitzpatrick added a commit to benfitzpatrick/cylc that referenced this issue Jul 14, 2014
benfitzpatrick added a commit to benfitzpatrick/cylc that referenced this issue Jul 14, 2014
benfitzpatrick added a commit to benfitzpatrick/cylc that referenced this issue Jul 14, 2014
benfitzpatrick added a commit to benfitzpatrick/cylc that referenced this issue Jul 17, 2014
benfitzpatrick added a commit to benfitzpatrick/cylc that referenced this issue Jul 22, 2014
hjoliver added a commit that referenced this issue Jul 23, 2014
@hjoliver
Copy link
Member Author

hjoliver commented Aug 5, 2014

Closed by #1011

@hjoliver hjoliver closed this as completed Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants