Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data store: flow numbers reported do not update to match reality #6114

Closed
MetRonnie opened this issue May 29, 2024 · 1 comment · Fixed by #6115
Closed

Data store: flow numbers reported do not update to match reality #6114

MetRonnie opened this issue May 29, 2024 · 1 comment · Fixed by #6115
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented May 29, 2024

Description

Once a task is added to the data store with particular flow numbers, these do not update when the task actually runs with different flow numbers

Reproducible Example

[scheduler]
    allow implicit tasks = True
    [[events]]
        startup handlers = cylc trigger %(workflow)s//2/a --flow=2 && cylc hold %(workflow)s//2/a
[scheduling]
    cycling mode = integer
    runahead limit = P0
    [[graph]]
        P1 = c[-P1] => a => b => c
[runtime]
    [[root]]
        script = sleep 5
cylc play <workflow-id> --pause

Using my branch to display flow nums in the UI tree view:

demo16

(Greyed out flow numbers are for "ghost tasks" that are not yet in the pool)

Expected Behaviour

1/c should be reported as flows=1 when it starts running. It is instead reported as flows=2 because the ghost task created by the data store was based off 2/a which was triggered in flow 2.

2/a should be reported as flows=1,2 when released, as flow merge has occurred from flow 1 catching up with flow 2. It instead continues to be reported as flow 2.

@MetRonnie MetRonnie added the bug Something is wrong :( label May 29, 2024
@MetRonnie MetRonnie added this to the 8.3.1 milestone May 29, 2024
@MetRonnie
Copy link
Member Author

MetRonnie commented May 29, 2024

I have a branch (see f8cf9bf) that attempts to fix this, however the fix results in traceback causing functional tests to fail which I don't understand.

E.g. tests/f/spawn-on-demand/06-stop-flow-2.t

@oliver-sanders oliver-sanders modified the milestones: 8.3.1, 8.3.2 Jul 3, 2024
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 1, 2024
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 1, 2024
oliver-sanders added a commit that referenced this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants