Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtriggers: autodocument template variables #443

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

oliver-sanders
Copy link
Member

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@oliver-sanders oliver-sanders requested a review from wxtim April 4, 2022 12:58
@wxtim
Copy link
Member

wxtim commented Apr 5, 2022

@oliver-sanders - do you know why the tests were failing?

@oliver-sanders
Copy link
Member Author

Yep, needed the PR marked as required in the OP merged.

@wxtim
Copy link
Member

wxtim commented Apr 6, 2022

Yep, needed the PR marked as required in the OP merged.

I think that I remember that PR had been merged when I kicked the CI yesterday - but I've kicked it again. If it passes I will merge...

(edit) - Sorry, no - CI run this morning (6th April) still failing.

@oliver-sanders
Copy link
Member Author

I don't think kicking CI has the desired effect in this case (the merge commit doesn't change for reruns?), rebased.

@wxtim wxtim merged commit 8c70813 into cylc:master Apr 6, 2022
@oliver-sanders oliver-sanders deleted the 4757 branch April 6, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants