Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc overhaul #310

Merged
merged 12 commits into from
Nov 15, 2021
Merged

Doc overhaul #310

merged 12 commits into from
Nov 15, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Oct 28, 2021

Attempting to knock the docs into shape as minimally and quickly as possible pre final beta release.

This PR should:

  • upgrade deprecated syntax
  • correct outright errors
  • make some sections more clear and concise
  • remove obsolete stuff (e.g. suicide triggers)
  • warn users where screenshots of the old desktop GUIs are still used
  • document new capabilities we've missed so far, if time allows, or else warn about what's still to be documented

Done:

  • migration guide
  • installation section
  • tutorial section

Will punt to other PRs:

  • main user guide
  • workflow design guide
  • reference section
  • glossary

@hjoliver hjoliver self-assigned this Oct 28, 2021
@oliver-sanders oliver-sanders added the content Addition or modification of documentation label Nov 8, 2021
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far.

@@ -234,6 +234,8 @@ Start, Stop, Restart

.. practical::

.. TODO - is this Met Office specific?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the bin directory is a script called get-observations. This script gets weather data from the MetOffice DataPoint service.

Also

$ rose tutorial runtime-tutorial

$ rose tutorial api-key

So not really a standalone Cylc practical??

and

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the tutorials used the rose tutorial command to safe people having to set up directories, copy files and all that stuff. For the "runtime" tutorial copying the files manually would be far too slow.

When we transferred the tutorials from Rose we transferred the tutorial files into this repo too, however, we do not presently have a Cylc alternative to the rose tutorial command.

This script gets weather data from the MetOffice DataPoint service

The DataPoint service was used for the Cylc forecasting tutorial, API keys for accessing the service are bundled with the suite so it is accessible to all. At the time DataPoint was the best offering that we could use without requiring users to setup accounts and so on. We will need to replace DataPoint soon as it is deprecated. We need point wind observations and a rainfall radar-like product. WOW may provide an answer but would require users to setup API keys etc.

@hjoliver hjoliver marked this pull request as ready for review November 9, 2021 04:21
@hjoliver
Copy link
Member Author

hjoliver commented Nov 9, 2021

Undrafted - this can be reviewed and merged as-is, I'll do the user guide etc. next, separately.

@oliver-sanders
Copy link
Member

<rst_epilog>:18:Duplicate explicit target name: "jupyter server".

@hjoliver
Copy link
Member Author

hjoliver commented Nov 9, 2021

The related issue is here: #40

Ah thanks, I'd forgotten about that whole conversation (2 years ago 😬 )

@hjoliver
Copy link
Member Author

The last commit comments out inclusion of the rose tutorial sections, pending #40

OK?

@hjoliver hjoliver mentioned this pull request Nov 10, 2021
20 tasks
@hjoliver
Copy link
Member Author

Also updated the beta software warning on the main index page.

@oliver-sanders
Copy link
Member

Note: The installation step will fail until the cylc-rose and cylc-uiserver PRs updating the setup.cfg files are merged.

@wxtim wxtim self-requested a review November 12, 2021 14:43
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not currently building properly for me:

?/cylc-doc/src/tutorial/runtime/configuration-consolidation/index.rst: WARNING: document isn't included in any toctree
?/cylc-doc/src/tutorial/runtime/introduction.rst: WARNING: document isn't included in any toctree
?/cylc-doc/src/tutorial/runtime/runtime-configuration.rst: WARNING: document isn't included in any toctree

Otherwise seems reasonable.

@oliver-sanders
Copy link
Member

(caused by #310 (comment))

@MetRonnie MetRonnie added this to the 8.0b3 milestone Nov 12, 2021
@hjoliver
Copy link
Member Author

OK, latest commit restores the tutorial sections with warnings. On closer inspection, they probably are still useful.

@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 15, 2021

Version conflict to be fixed by #312

(note the tests build against project master branches which are now diverging from 8.0b3)

@oliver-sanders oliver-sanders requested a review from wxtim November 15, 2021 10:44
@wxtim wxtim merged commit 94839b9 into cylc:master Nov 15, 2021
@hjoliver hjoliver deleted the doc-overhaul branch November 16, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Addition or modification of documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants