-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc overhaul #310
Doc overhaul #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so far.
@@ -234,6 +234,8 @@ Start, Stop, Restart | |||
|
|||
.. practical:: | |||
|
|||
.. TODO - is this Met Office specific? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the bin directory is a script called get-observations. This script gets weather data from the MetOffice DataPoint service.
Also
$ rose tutorial runtime-tutorial
$ rose tutorial api-key
So not really a standalone Cylc practical??
and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the tutorials used the rose tutorial
command to safe people having to set up directories, copy files and all that stuff. For the "runtime" tutorial copying the files manually would be far too slow.
When we transferred the tutorials from Rose we transferred the tutorial files into this repo too, however, we do not presently have a Cylc alternative to the rose tutorial
command.
- The files are now in this repo e.g: https://github.com/cylc/cylc-doc/blob/master/cylc/doc/etc/tutorial/api-keys
- They can be accessed via GH-Pages e.g: https://cylc.github.io/cylc-doc/nightly/html/_static/tutorial/api-keys
- Or if cylc-doc is installed they are included in the package e.g:
Path(cylc.doc.__file__.parent) / 'etc/api-keys'
- The related issue is here: Cylc Tutorial Suite #40
This script gets weather data from the MetOffice DataPoint service
The DataPoint service was used for the Cylc forecasting tutorial, API keys for accessing the service are bundled with the suite so it is accessible to all. At the time DataPoint was the best offering that we could use without requiring users to setup accounts and so on. We will need to replace DataPoint soon as it is deprecated. We need point wind observations and a rainfall radar-like product. WOW may provide an answer but would require users to setup API keys etc.
dbccf46
to
080e5ed
Compare
Undrafted - this can be reviewed and merged as-is, I'll do the user guide etc. next, separately. |
|
Ah thanks, I'd forgotten about that whole conversation (2 years ago 😬 ) |
The last commit comments out inclusion of the OK? |
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Also updated the beta software warning on the main index page. |
ad5685b
to
5a75806
Compare
Note: The installation step will fail until the cylc-rose and cylc-uiserver PRs updating the setup.cfg files are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not currently building properly for me:
?/cylc-doc/src/tutorial/runtime/configuration-consolidation/index.rst: WARNING: document isn't included in any toctree
?/cylc-doc/src/tutorial/runtime/introduction.rst: WARNING: document isn't included in any toctree
?/cylc-doc/src/tutorial/runtime/runtime-configuration.rst: WARNING: document isn't included in any toctree
Otherwise seems reasonable.
(caused by #310 (comment)) |
OK, latest commit restores the tutorial sections with warnings. On closer inspection, they probably are still useful. |
Version conflict to be fixed by #312 (note the tests build against project master branches which are now diverging from 8.0b3) |
Attempting to knock the docs into shape as minimally and quickly as possible pre final beta release.
This PR should:
Done:
Will punt to other PRs: