Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first go at revised clock-trigger tutorial #181

Merged
merged 2 commits into from
Jan 8, 2021
Merged

first go at revised clock-trigger tutorial #181

merged 2 commits into from
Jan 8, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Dec 17, 2020

Should Close #61
Questions:

  • I'm I emphasizing that clock triggers are a special case of xtriggers (gateway). Good Idea?
  • I don't go into specifics or much detail about my_trigger = wall_clock(offset=PT0H):<ISOdatetime freq>. Should I?

@wxtim wxtim marked this pull request as draft December 17, 2020 17:10
@oliver-sanders
Copy link
Member

oliver-sanders commented Dec 17, 2020 •
edited
Loading

Looks good.

No need to go much deeper as with the tutorial re-write we will likely integrate clock triggers.

@wxtim wxtim marked this pull request as ready for review December 17, 2020 19:45
@wxtim
Copy link
Member Author

wxtim commented Dec 17, 2020 •
edited
Loading

Failing in the same way as master. 😞 I think #180 will fix the problem. :)

@wxtim wxtim force-pushed the tutorials.clock-triggers-xtriggers branch from 50de543 to f043091 Compare December 18, 2020 09:05
@wxtim wxtim requested a review from MetRonnie December 21, 2020 11:44
MetRonnie
MetRonnie approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the test failure due to the tutorial suite datapoint for now

@wxtim wxtim closed this Dec 21, 2020
@wxtim wxtim reopened this Dec 21, 2020
@oliver-sanders oliver-sanders merged commit 7d95fc3 into cylc:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tutorial: upgrade clock-triggers => xtriggers
3 participants
@wxtim @oliver-sanders @MetRonnie