fix: renamed attribute should remain enumerable #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b6630b to
f630bf0
Compare
cyjake
commented
Jul 8, 2021
| @@ -126,6 +126,10 @@ module.exports = Bone => { | |||
| return true; | |||
| } | |||
|
|
|||
| static get Instance() { | |||
| return this; | |||
| } | |||
cyjake
commented
Jul 8, 2021
| ]); | ||
| User.renameAttribute('foo', 'bar'); | ||
| assert.ok(Object.getOwnPropertyDescriptor(User.prototype, 'bar').enumerable); | ||
| }); |
There was a problem hiding this comment.
It's expected that attributes should always present in toJSON() or toObject() results. Make renamed attribute enumerable as well.
JimmyDaddy
reviewed
Jul 8, 2021
even if there is getter method with same name
Co-authored-by: JimmyDaddy <heyjimmygo@gmail.com>
91fb779 to
e161ec3
Compare
JimmyDaddy
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if there is getter method with same name. Also added
Model.Instancein sequelize adapter