This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
[RFR-409] Fix Websocket in Vert.X #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hb0
commented
May 2, 2023
| final var options = new HttpServerOptions(); | ||
| options.setCompressionSupported(true); | ||
| // Make server respond with one of the sub-protocols sent by our client, in our case: ['Bearer', 'eyToken***']. | ||
| // When the server does not respond with one of both options, the websocket client won't accept the connection. | ||
| // The protocol name "Bearer" is made up, but injecting the auth token via protocol is a common workaround | ||
| // for the issue that the Javascript Websocket class does not allow to add an `Authorization` header [RFR-165]. | ||
| options.setWebSocketSubProtocols(Collections.singletonList("Bearer")); | ||
| options.setRegisterWebSocketWriteHandlers(true); |
There was a problem hiding this comment.
this fixes the bug in the provider
| @@ -81,7 +81,7 @@ subprojects { | |||
| // If you increase this version, check if the `collector.GridFSStorageIT` breaks | |||
| // There is a bug up to version 4.4.1, scheduled to be fixed in 4.4.2 | |||
| // https://github.com/vert-x3/vertx-mongo-client/issues/291 | |||
| vertxVersion = '4.3.6' | |||
| vertxVersion = '4.4.1' // FIXME: Don't release yet as this version does not work with collector. | |||
There was a problem hiding this comment.
FIXME: We cannot merge release this PR yet, as the Collector cannot upgrade to this Vert.X version
e37c754 to
8afeafe
Compare
8afeafe to
3fd4a01
Compare
f85f1ac to
432ee36
Compare
432ee36 to
569366f
Compare
fbc6849 to
ddeb037
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR blocked because of an open issue in the current Vert.X version, now fixed in 4.4.4 yet:
vert-x3/vertx-mongo-client#291
But the provider already uses this PR, release as
2.1.3-beta2