Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qps flag #518

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add qps flag #518

merged 1 commit into from
Mar 27, 2023
+14 −1

Conversation

kmdkuk
Copy link
Contributor

@kmdkuk kmdkuk commented Mar 17, 2023 •
edited
Loading

ref #517

Signed-off-by: kouki kouworld0123@gmail.com

@kmdkuk kmdkuk self-assigned this Mar 17, 2023
@kmdkuk
Add qps flag
dbd4f32 
Signed-off-by: kouki <kouworld0123@gmail.com>
@kmdkuk kmdkuk requested a review from masa213f March 17, 2023 03:08
masa213f
masa213f requested changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a metric for counting the requests to API servers.
We need the metrics to adjust this option.

@masa213f
Copy link
Contributor

Please add a metric for counting the requests to API servers.

rest_client_requests_total{namespace="moco-system"} is already exists.

masa213f
masa213f approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit 5151505 into main Mar 27, 2023
@masa213f masa213f deleted the add-qps-flag branch March 27, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masa213f masa213f masa213f approved these changes

Assignees

@kmdkuk kmdkuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmdkuk @masa213f