Disable the delay check if .spec.maxDelaySeconds == 0 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
|
Do we have to test the case of maxDelaySeconds == 0 and nil? |
umezawatakeshi
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior when
.spec.maxDelaySecondsis0.We made it possible to disable the delay check when
.spec.maxDelaySecondsis0in #434.However, that change seemed to be incorrect, so I fixed it.
In the current implementation, if we set
.spec.maxDelaySeconds: 0in the MySQLCluster, the default value (60s) is used as a delay.Because MOCO (or kube-apiserver) cannot distinguish whether the
0is the zero value of integer type or intentionally set.This PR changes the type of
maxDelaySecondsto the pointer of int. This will allow the MOCO to determine if the 0 is set intentionally or not.Signed-off-by: Masayuki Ishii masa213f@gmail.com