Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reusing workflow #465

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Use reusing workflow #465

merged 8 commits into from
Nov 8, 2022

Conversation

d-kuro
Copy link
Contributor

@d-kuro d-kuro commented Sep 27, 2022 •
edited
Loading

There are many versions of MySQL supported by MOCO.

MySQL: 8.0.18, 8.0.25, 8.0.26, 8.0.27, 8.0.28, 8.0.30

Since the matrix test will continue to grow if this is not done, the following policy is established.

  • Determine the MySQL version of the LTS
    • This is the version that Cybozu uses internally
  • In addition to the LTS version, CI will run the latest and one of the previous versions
  • Matrix tests for all supported MySQL versions are run on a weekly basis

@d-kuro d-kuro self-assigned this Sep 27, 2022
@d-kuro d-kuro force-pushed the d-kuro/workflow branch 4 times, most recently from 4a8292a to b6fc476 Compare September 27, 2022 18:51
@d-kuro
Use reusing workflow
1c38df1 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
@d-kuro d-kuro force-pushed the d-kuro/workflow branch 3 times, most recently from fb14580 to b9a63d1 Compare September 28, 2022 02:11
@d-kuro
Split workflow file
9654ce2 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
@d-kuro
Add weekly workflows
9edbfda 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
@d-kuro
Update develop docs
ecccb29 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
@d-kuro d-kuro marked this pull request as ready for review September 28, 2022 03:51
@d-kuro d-kuro requested a review from masa213f September 28, 2022 03:51
d-kuro added 2 commits October 5, 2022 12:45
@d-kuro
Add manual execution for weekly tests
2fd88b4 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
@d-kuro
Run all versions of the test when it is pushed to the bump branch
7c39c4b 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
masa213f
masa213f requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good improvements!

Please make a few changes.

  • We use MySQL 8.0.28 internally. So MySQL 8.0.18 no longer needs to test in each PR.
  • Basically, we continue to maintain all supported MySQL. I'm afraid that the word LTS is not suitable. Could you replace it with another word in some comments?

d-kuro added 2 commits November 2, 2022 13:38
@d-kuro
Use MySQL 8.0.27 as min version
664de20 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
@d-kuro
Do not use the word LTS
78f8dd2 
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
masa213f
masa213f approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@masa213f masa213f merged commit a01ef31 into main Nov 8, 2022
@masa213f masa213f deleted the d-kuro/workflow branch November 8, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masa213f masa213f masa213f approved these changes

Assignees

@d-kuro d-kuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-kuro @masa213f