Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ShaderCOptions.includeDirs to an array of C strings #2

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

samloeschen
Copy link
Contributor

@samloeschen samloeschen commented Jul 6, 2024

Avoids segfault when providing more than one include path. [:0]const u8 strings seem to work fine everywhere else, but includeDirs needs to be a [*c]const u8 to keep shaderc happy

@OndraVoves
Copy link
Member

Nice catch 😄 there is same problem with defines and dependencies in the same struct. Can you please fix it in your MR?

P.S.: Add yourself to section ## Other Contributors in AUTHORS.md ;)

@samloeschen
Copy link
Contributor Author

done and done! bindings have been great so far btw 👍

@OndraVoves
Copy link
Member

Nice and Thanks ;)

@OndraVoves OndraVoves self-assigned this Jul 7, 2024
@OndraVoves OndraVoves added the bug Something isn't working label Jul 7, 2024
@OndraVoves OndraVoves merged commit 2e9e96d into cyberegoorg:main Jul 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants