This repository has been archived by the owner on Jan 29, 2019. It is now read-only.
Chain pump fixed #39
Merged
Chain pump fixed #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support of reorganisation
vbloher
suggested changes
Dec 28, 2017
| val fl = ConcurrentPulledBlockchain(blockchain) | ||
| val context = ConvertContext( | ||
| exHash = "", | ||
| history = StackCache(20), |
There was a problem hiding this comment.
use constants values in such situations
| } | ||
|
|
||
| fun generateEvents(blockchain: BlockchainInterface<*>, startBlockNumber: Long): Flowable<out BlockchainEvent> { | ||
| val fl = ConcurrentPulledBlockchain(blockchain) |
There was a problem hiding this comment.
Is it possible to give a more informative name for a variable
| } | ||
|
|
||
| fun convert(_blockBundle: BlockBundle, context: ConvertContext): List<BlockchainEvent> { | ||
| var blockBundle = _blockBundle |
There was a problem hiding this comment.
should you refactor this without using "_"
| context.history.push(blockBundle) | ||
| events = listOf(CommitBlock(blockBundle)) | ||
| } else { | ||
| var exBl: BlockBundle? = null |
| val jsonSerializer = ObjectMapper() | ||
| val jsonDeserializer = ObjectMapper() | ||
| val jsonSerializer = ObjectMapper().registerKotlinModule() | ||
| .registerModule(Jdk8Module()) |
vbloher
approved these changes
Dec 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.