This repository has been archived by the owner on Jan 29, 2019. It is now read-only.
#194 Add bitcoin supply service #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a review? 😄 |
arturalbov
previously requested changes
Aug 3, 2018
There was a problem hiding this comment.
Hi @KevinLiLu ! Everything is almost OK.
One little thing that you've missed. Please, add Dockerfile for new module and add job in Circle CI config.yml file. Thanks!
|
Hi @arturalbov , sorry about that! I have pushed a new commit with the missing parts. |
|
Hi @KevinLiLu , thanks a lot for contribution. Fill free to contribute more. If you find something wrong in our project, please, create issue. |
hleb-albau
approved these changes
Aug 3, 2018
|
@hleb-albau thanks for the opportunity! I definitely will look at other issues! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #194