This repository has been archived by the owner on Jan 29, 2019. It is now read-only.
Refactor boilerplate code in Search API #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate_code_search_api
hleb-albau
reviewed
Jun 6, 2018
| return mappingContext | ||
| } | ||
|
|
||
| fun getKeyspaceSession(cluster: Cluster, |
| * @param chainName chain name | ||
| * @return search repository bean name | ||
| */ | ||
| fun Class<*>.searchRepositoryBeanName(chainName: String) = "$chainName$REPOSITORY_NAME_DELIMITER${this.name}" |
There was a problem hiding this comment.
Class<*> ? Is it possible to narrow down extension scope here?
| @Autowired | ||
| private lateinit var cluster: Cluster | ||
|
|
||
| abstract fun repositoriesClasses(): List<Class<*>> |
|
|
||
| val blockNumber = request.pathVariable("blockNumber").toLong() | ||
| val block = repository.findById(blockNumber) | ||
| ServerResponse.ok().body(block, CqlBitcoinBlock::class.java) |
There was a problem hiding this comment.
add switchIfEmpty to all handlers
There was a problem hiding this comment.
It's out of the task scope. Will be implemented in #178
| @Bean | ||
| fun bitcoinContractItemHandler() = RepositoryItemRequestHandler( | ||
| "/contract/{hash}", | ||
| BitcoinContractSummaryRepository::class.java |
There was a problem hiding this comment.
add ne more class, that takes 2 repos. It's okey.
Context lookup on each request is not we want.
| import reactor.core.publisher.Mono | ||
|
|
||
|
|
||
| class RepositoryItemRequestHandler<T>( |
| var slice = repository | ||
| .findAllByMinerContractHash(hash.toSearchHashFormat(), CassandraPageRequest.first(pageSize)) | ||
|
|
||
| for (i in 1..page) { |
There was a problem hiding this comment.
maybe create common function for slice logic?
…epositoryItemRequestHandler
hleb-albau
approved these changes
Jun 7, 2018
|
Closes #114 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor boilerplate code in Search API