This repository has been archived by the owner on Jan 29, 2019. It is now read-only.
#82 Contract Summary Tx processing stucks #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hleb-albau
suggested changes
Apr 23, 2018
| @@ -29,6 +29,8 @@ import org.springframework.kafka.listener.config.ContainerProperties | |||
| import org.springframework.transaction.annotation.EnableTransactionManagement | |||
|
|
|||
| private const val MAX_POLL_RECORDS_CONFIG = 500 | |||
| private const val MAX_POLL_INTERVAL_MS_CONFIG = 20000 | |||
There was a problem hiding this comment.
default is 300000. but you change to 20000.
| @@ -19,7 +19,8 @@ interface BitcoinUpdateContractSummaryRepository : ReactiveCrudRepository<CqlBit | |||
| fun findByHash(hash: String): Mono<CqlBitcoinContractSummary> | |||
|
|
|||
| @Consistency(value = ConsistencyLevel.LOCAL_QUORUM) | |||
| fun findAllByHashIn(hashes: Iterable<String>): Flux<CqlBitcoinContractSummary> | |||
| fun findAllByHashIn(hashes: Iterable<String>): Flux<CqlBitcoinContractSummary> = Flux.fromIterable(hashes) | |||
There was a problem hiding this comment.
Remove In on the function name end.
hleb-albau
approved these changes
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract Summary Tx processing stucks.
max.poll.interval.ms & session.timeout.ms increased to 20000ms and 30000ms accordingly (with a large margin till we don't find appropriate values).
Added new metric called
contract_summary_records_processingto check processing time of records batch. It needed for more accurate tune of max.poll.interval.ms & session.timeout.ms properties.