Skip to content
This repository has been archived by the owner on Jan 29, 2019. It is now read-only.

Ethereum block and uncles rewards should be calculated by block traces #185

Closed
2 tasks
hleb-albau opened this issue May 23, 2018 · 11 comments · Fixed by #256
Closed
2 tasks

Ethereum block and uncles rewards should be calculated by block traces #185

hleb-albau opened this issue May 23, 2018 · 11 comments · Fixed by #256

Comments

@hleb-albau
Copy link
Contributor

hleb-albau commented May 23, 2018

Overview

Here you can explore our project


Task description

Right now, in Ethereum Pump we use self written inflation function to calculate miners rewards. If inflation changes, we should fix code. But, there is better solution exists:
We already call parity method 'block_traces' for transactions, which also returns miners and uncles rewards calls. Ethereum pump should calculate mining rewards using this calls.


Required knowledge

  • Parity rpc api
  • Kotlin
  • JUnit

Contribution rules

Here you can learn how to contribute to our project


Definition of done

Start point: ParityToEthereumBundleConverter:convert(rawData: BundleRawData): EthereumBlockBundle. BundleRawData contains required traces.

  • Mining and uncles rewards calculated via parity block trace calls.
  • JUnit tests covers uncles rewards calculated via parity block trace calls.

Extra information

Bounty amount 0.1 ETH
Experience level beginner
Project length 4 hours
Expires in 1 month
Bounty type enchansment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.1 ETH (59.43 USD @ $594.3/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Jun 19, 2018

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 1 month, 3 weeks ago.
Please review their action plans below:

  1. rafaelboyero has started work.

Learn more on the Gitcoin Issue Details page.

  1. KevinLiLu has started work.

    What steps will you take to complete this task?

Since we already call trace_block, we have all the block and uncle rewards given in the call so we just need to check the "rewardType" to calculate block and uncle rewards.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of this issue was increased to 0.25 ETH (67.18 USD @ $268.74/ETH) .

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 0.25 ETH (68.67 USD @ $274.7/ETH) attached to this issue has been cancelled by the bounty submitter

@hleb-albau hleb-albau reopened this Aug 26, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.25 ETH (68.69 USD @ $274.74/ETH) attached to it.

@hleb-albau
Copy link
Contributor Author

hleb-albau commented Aug 26, 2018

Hi @KevinLiLu. I mistaken during payout. Gitcoin canceled bounty, returned funds to me, and signed tx from my account to 0xf0840bba371d70581706bd15282fb1ab08d1a6f4 address. For better history, could, you please return funds back, and I will correctly submit issue.

@gitcoinbot
Copy link

gitcoinbot commented Aug 26, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

  1. KevinLiLu has started work.

    Since we already call trace_block, we have all the block and uncle rewards given in the call so we just need to check the "rewardType" to calculate block and uncle rewards.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.25 ETH (68.2 USD @ $272.79/ETH) has been submitted by:

  1. @KevinLiLu

@hleb-albau please take a look at the submitted work:


@hleb-albau
Copy link
Contributor Author

@KevinLiLu is it your address 0xf0840bba371d70581706bd15282fb1ab08d1a6f4?

@KevinLiLu
Copy link
Contributor

@hleb-albau Nope, my address is 0x6de8f1204616773af4193d3bdbada325e9bf9679

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.25 ETH (71.29 USD @ $285.16/ETH) attached to this issue has been approved & issued to @KevinLiLu.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants