Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snap creation from Ubuntu 20.04 to Ubuntu 22.04 #62

Merged
merged 39 commits into from
Dec 9, 2024
Merged

Update snap creation from Ubuntu 20.04 to Ubuntu 22.04 #62

merged 39 commits into from
Dec 9, 2024

Conversation

MNikoliCC
Copy link
Contributor

@MNikoliCC MNikoliCC commented Dec 4, 2024 •
edited
Loading

Description
Update snap creation from Ubuntu 20.04 to Ubuntu 22.04.

Tasks
Add the list of tasks of this PR.

  • Update to Ubuntu 22.04
  • Remove ROS 1
  • Update dependencies

@MNikoliCC MNikoliCC added the test creation Start the creation of the snap package label Dec 4, 2024
@MNikoliCC MNikoliCC self-assigned this Dec 4, 2024
@MNikoliCC MNikoliCC marked this pull request as draft December 4, 2024 13:05
@lukicdarkoo
Copy link
Member

@MNikoliCC Can you also fix this failed CI (in the same PR):
https://github.com/cyberbotics/webots-snap/actions/runs/12149775429

@MNikoliCC
Copy link
Contributor Author

@MNikoliCC Can you also fix this failed CI (in the same PR): https://github.com/cyberbotics/webots-snap/actions/runs/12149775429

It should be resolved now.

@MNikoliCC MNikoliCC marked this pull request as ready for review December 9, 2024 14:18
@MNikoliCC MNikoliCC requested a review from lukicdarkoo December 9, 2024 14:18
lukicdarkoo
lukicdarkoo approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I will merge. I know the second last commit didn't produce installable snap, but hopefully the last commit fixed it. If not, we will create another PR. I want to test whether the scheduled CI does the job

@lukicdarkoo lukicdarkoo merged commit e0def21 into master Dec 9, 2024
3 checks passed
@lukicdarkoo lukicdarkoo deleted the feature-update-to-ubuntu22.04 branch December 9, 2024 21:50
MNikoliCC added a commit that referenced this pull request Dec 19, 2024
@MNikoliCC
Revert "Update snap creation from Ubuntu 20.04 to Ubuntu 22.04 (#62)"
62775f0 
This reverts commit e0def21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukicdarkoo lukicdarkoo lukicdarkoo approved these changes

Assignees

@MNikoliCC MNikoliCC

Labels
test creation Start the creation of the snap package
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MNikoliCC @lukicdarkoo