clean up unit tests

cweagans · Feb 12, 2023 · f7d1cd6 · f7d1cd6
1 parent c26cbf3
commit f7d1cd6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/tests/unit/CoreDownloaderProviderTest.php b/tests/unit/CoreDownloaderProviderTest.php
@@ -10,6 +10,7 @@
 use Composer\Plugin\PluginInterface;
 use cweagans\Composer\Capability\Downloader\CoreDownloaderProvider;
 use cweagans\Composer\Downloader\ComposerDownloader;
+use cweagans\Composer\Downloader\DownloaderInterface;
 
 class CoreDownloaderProviderTest extends Unit
 {
@@ -27,6 +28,6 @@ public function testGetDownloaders()
         $downloaders = $downloaderProvider->getDownloaders();
 
         $this->assertCount(1, $downloaders);
-        $this->assertInstanceOf(ComposerDownloader::class, $downloaders[0]);
+        $this->assertContainsOnlyInstancesOf(DownloaderInterface::class, $downloaders);
     }
 }
diff --git a/tests/unit/CorePatcherProviderTest.php b/tests/unit/CorePatcherProviderTest.php
@@ -8,6 +8,7 @@
 use Composer\IO\NullIO;
 use Composer\Plugin\PluginInterface;
 use cweagans\Composer\Capability\Patcher\CorePatcherProvider;
+use cweagans\Composer\Patcher\PatcherInterface;
 use cweagans\Composer\Patcher\BsdPatchPatcher;
 use cweagans\Composer\Patcher\GitPatcher;
 use cweagans\Composer\Patcher\GitInitPatcher;
@@ -27,10 +28,6 @@ public function testGetPatchers()
         $patchers = $patcherProvider->getPatchers();
 
         $this->assertCount(5, $patchers);
-        $this->assertInstanceOf(GitPatcher::class, $patchers[0]);
-        $this->assertInstanceOf(GitInitPatcher::class, $patchers[1]);
-        $this->assertInstanceOf(GnuPatchPatcher::class, $patchers[2]);
-        $this->assertInstanceOf(GnuGPatchPatcher::class, $patchers[3]);
-        $this->assertInstanceOf(BsdPatchPatcher::class, $patchers[4]);
+        $this->assertContainsOnlyInstancesOf(PatcherInterface::class, $patchers);
     }
 }
diff --git a/tests/unit/CoreResolverProviderTest.php b/tests/unit/CoreResolverProviderTest.php
@@ -9,6 +9,7 @@
 use Composer\Plugin\PluginInterface;
 use cweagans\Composer\Capability\Resolver\CoreResolverProvider;
 use cweagans\Composer\Resolver\PatchesFile;
+use cweagans\Composer\Resolver\ResolverInterface;
 use cweagans\Composer\Resolver\RootComposer;
 
 class CoreResolverProviderTest extends Unit
@@ -24,7 +25,6 @@ public function testGetResolvers()
         $resolvers = $resolverProvider->getResolvers();
 
         $this->assertCount(2, $resolvers);
-        $this->assertInstanceOf(RootComposer::class, $resolvers[0]);
-        $this->assertInstanceOf(PatchesFile::class, $resolvers[1]);
+        $this->assertContainsOnlyInstancesOf(ResolverInterface::class, $resolvers);
     }
 }