-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment/testing with Python 3.10 #1593
Conversation
@phschiele @akshayka I'm getting pretty close to getting 3.10 working. I'm getting a weird bug I can't reproduce locally involving diffcp: https://github.com/cvxpy/cvxpy/runs/4628602909?check_suite_focus=true#step:6:4333 Edit: Looks like SCS is failing to solve the problem... |
@SteveDiamond I think I found the issue: |
@SteveDiamond I found two more occurrences where the Python versions are listed explicitly: |
Co-authored-by: phschiele <44360364+phschiele@users.noreply.github.com>
@phschiele thanks so much for figuring it out! I'm also having some problems building wheels for 3.10. Not totally sure what's going on there: https://github.com/cvxgrp/diffcp/runs/4632902674?check_suite_focus=true#step:7:53 Edit: I tried fixing this by upping the cibuildwheel version, but then windows builds failed :( |
* 'py310' of github.com:cvxpy/cvxpy: Update continuous_integration/install_dependencies.sh
Integrating a version of #1559 |
Edit: Nvm, it's failing to build wheels on ubuntu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveDiamond This looks good 🚀
I hade one small remark about the diffcp interface above.
A second detail is that some of the environment variables like the PyPI settings are now unused in the build
workflow and could be removed there.
Kudos, SonarCloud Quality Gate passed! |
- name: Build wheels | ||
if: ${{env.DEPLOY == 'True' && env.USE_OPENMP != 'True'}} | ||
if: ${{'True' == 'True' && env.USE_OPENMP != 'True'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveDiamond Just a reminder to undo these shortcuts after everything is confirmed working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm going to let it build the wheels once on master and then undo them.
No description provided.