Dev #20
Merged
Dev #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combining work
New class to support CQE ADMM
bmeyers
commented
Jun 6, 2024
| @@ -37,7 +37,10 @@ def prepare_attributes(self, T, p=1): | |||
| self._Pz = sp.block_diag([ | |||
| c._Pz for c in self._gf_list | |||
| ]) | |||
| self._make_q() | |||
| # same logic as above but for q | |||
There was a problem hiding this comment.
add comment: this is related to "close to input vector" class, which is incomplete and ready for use. q is still set to be zero for all implemented classes.
bmeyers
commented
Jun 6, 2024
| @@ -53,6 +56,9 @@ def _make_P(self): | |||
| c._Pz for c in self._gf_list | |||
| ]) | |||
|
|
|||
| def _make_r(self): | |||
There was a problem hiding this comment.
comment: still always set to zero
bmeyers
commented
Jun 6, 2024
| @@ -53,6 +53,34 @@ def _make_B(self): | |||
| def _make_c(self): | |||
| self._c = np.concatenate([np.atleast_1d(self._c[-1]), | |||
| [self._last_val]]) | |||
|
|
|||
|
|
|||
| class ValsEqual(GraphComponent): | |||
There was a problem hiding this comment.
incomplete and no intention to finish at this time
There was a problem hiding this comment.
add not implemented warning
bmeyers
commented
Jun 6, 2024
| @@ -9,17 +11,65 @@ def __init__(self, *args, **kwargs): | |||
| def _make_P(self, size): | |||
| return self.weight * 2 * sp.eye(size) # note the (1/2) in canonical form! | |||
|
|
|||
|
|
|||
| class SumSquareReference(GraphComponent): | |||
| """ | |||
There was a problem hiding this comment.
add not implemented warning?
Fix builds and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.