add ut

pkg/blob/nodeserver.go

@@ -584,17 +584,21 @@ func (d *Driver) ensureMountPoint(target string, perm os.FileMode) (bool, error)
 }
 
 func waitForMount(path string, intervel, timeout time.Duration) error {
+	timeAfter := time.After(timeout)
+	timeTick := time.Tick(intervel)
+
 	for {
 		select {
-		case <-time.After(intervel):
+		case <-timeTick:
 			notMount, err := mount.New("").IsLikelyNotMountPoint(path)
 			if err != nil {
 				return err
 			}
 			if !notMount {
+				klog.V(2).Infof("blobfuse mount at %s success", path)
 				return nil
 			}
-		case <-time.After(timeout):
+		case <-timeAfter:
 			return fmt.Errorf("timeout waiting for mount %s", path)
 		}
 	}

pkg/blob/nodeserver_test.go

@@ -24,8 +24,10 @@ import (
 	"path/filepath"
 	"reflect"
 	"runtime"
+	"strings"
 	"syscall"
 	"testing"
+	"time"
 
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/codes"
@@ -754,3 +756,51 @@ func TestMountBlobfuseInsideDriver(t *testing.T) {
 	// the error should be of type exec.ExitError
 	assert.NotNil(t, err)
 }
+
+func Test_waitForMount(t *testing.T) {
+	type args struct {
+		path     string
+		intervel time.Duration
+		timeout  time.Duration
+	}
+
+	tests := []struct {
+		name      string
+		args      args
+		wantErr   bool
+		subErrMsg string
+	}{
+		{
+			name: "test timeout",
+			args: args{
+				path:     "/",
+				intervel: 1 * time.Millisecond,
+				timeout:  10 * time.Millisecond,
+			},
+			wantErr:   true,
+			subErrMsg: "timeout",
+		},
+		{
+			name: "test no such file or directory",
+			args: args{
+				path:     "",
+				intervel: 1 * time.Millisecond,
+				timeout:  10 * time.Millisecond,
+			},
+			wantErr:   true,
+			subErrMsg: "no such file or directory",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := waitForMount(tt.args.path, tt.args.intervel, tt.args.timeout)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("waitForMount() error = %v, wantErr %v", err, tt.wantErr)
+			}
+			if err != nil && !strings.Contains(err.Error(), tt.subErrMsg) {
+				t.Errorf("waitForMount() error = %v, wantErr %v", err, tt.subErrMsg)
+			}
+		})
+	}
+}