Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated maxWorkers by numWorker #9029

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 30, 2025

Motivation and context

maxWorkers deprecated in nuclio 1.13.x (currently suggested by CVAT)
Warning message suggest to replace with numWorkers

https://docs.nuclio.io/en/1.13.x/reference/function-configuration/function-configuration-reference.html

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (7484e4d) to head (f2c8b42).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9029   +/-   ##
========================================
  Coverage    73.43%   73.44%           
========================================
  Files          418      418           
  Lines        44299    44299           
  Branches      3870     3870           
========================================
+ Hits         32533    32536    +3     
+ Misses       11766    11763    -3     
Components Coverage Δ
cvat-ui 77.44% <ø> (+0.01%) ⬆️
cvat-server 70.12% <ø> (ø)

@bsekachev bsekachev merged commit 559178e into develop Jan 31, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants