Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvat_sdk.auto_annotation.functions: don't declare useless "N/A" labels #8997

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jan 27, 2025

Motivation and context

"N/A" is how torchvision marks the gaps in the COCO label list. Since these "labels" should never be output by the models, we should avoid declaring them.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

"N/A" is how torchvision marks the gaps in the COCO label list. Since these
"labels" should never be output by the models, we should avoid declaring
them.
@SpecLad SpecLad marked this pull request as ready for review January 27, 2025 14:17
@SpecLad SpecLad requested a review from nmanovic as a code owner January 27, 2025 14:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.39%. Comparing base (eb2fe04) to head (c33481a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8997   +/-   ##
========================================
  Coverage    73.39%   73.39%           
========================================
  Files          415      415           
  Lines        44184    44184           
  Branches      3859     3859           
========================================
+ Hits         32427    32431    +4     
+ Misses       11757    11753    -4     
Components Coverage Δ
cvat-ui 77.38% <ø> (+0.01%) ⬆️
cvat-server 70.08% <ø> (ø)

@SpecLad SpecLad merged commit 99e9430 into cvat-ai:develop Jan 27, 2025
40 of 42 checks passed
@SpecLad SpecLad deleted the torchvision-na branch January 27, 2025 15:15
@cvat-bot cvat-bot bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants