Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A job cannot be opened if to remove an image with the latest keyframe of a track #8952

Merged
merged 12 commits into from
Jan 20, 2025

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 16, 2025

Motivation and context

Depends on #8951

From the design perspective, we do not use deleted images to calculate positions (the idea is to treat the job as if these images do not exist). However, this can lead to situations where track keyframes are missing, making it impossible to open the job. With this patch, such errors will be properly handled, and these objects will not be displayed at all.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from nmanovic as a code owner January 16, 2025 16:50
@bsekachev bsekachev changed the base branch from develop to bs/fixed_deleted_frames January 16, 2025 17:12
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (bs/fixed_deleted_frames@73a98d2). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             bs/fixed_deleted_frames    #8952   +/-   ##
==========================================================
  Coverage                           ?   73.84%           
==========================================================
  Files                              ?      417           
  Lines                              ?    44593           
  Branches                           ?     4031           
==========================================================
  Hits                               ?    32928           
  Misses                             ?    11665           
  Partials                           ?        0           
Components Coverage Δ
cvat-ui 78.28% <0.00%> (?)
cvat-server 70.06% <0.00%> (?)

@bsekachev bsekachev merged commit 2b69629 into bs/fixed_deleted_frames Jan 20, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants