Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to confirm correct UI and cache state after frame deletion #8949
Test to confirm correct UI and cache state after frame deletion #8949
Changes from 10 commits
436e535
041b822
7895416
a5782c9
d6e5503
a5b10b5
b6e3c09
d31f244
14f3719
bda12c7
07248de
5aff8f2
60e1048
782fb92
dbae90e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will suggest being more specific here in naming if we add global Cypress command.
We probably have many
Save
buttons across the application.So, maybe
clickSaveAnnotationView
.Additionally I will ask to search by
contains('Save').click
over the tests and replace findingsI found at least two more places with this code (case 92, case 91):